ChaosStuff/cnc-dashboard Changeset - 30b325c925ad · Chaos Computer Club Lëtzebuerg Projects

Changeset - 30b325c925ad

Parent rev.

Child rev.

[Approved]

0 1 0

Dennis Fink - 23 months ago 2022-06-08 22:20:40
dennis.fink@c3l.lu

Double quote to prevent globbing and word splitting.

https://www.shellcheck.net/wiki/SC2086

1 file changed with 10 insertions and 10 deletions:

flashEMMC.sh

2 comments (0 inline, 2 general)

flashEMMC.sh

➞

Show inline comments

@@ @@ -11,8 +11,8 @@ checkRoot() { @@
+}
 diskInfo() {
 	[[ -e /dev/$DEV ]] || { echo "ERROR: Drive doesn't exist" && exit 1; }
 	fdisk -l /dev/$DEV
 	[[ -e /dev/"$DEV" ]] || { echo "ERROR: Drive doesn't exist" && exit 1; }
 	fdisk -l /dev/"$DEV"
 	echo
+}
@@ @@ -29,18 +29,18 @@ verifyRightDrive() { @@
+}
 umountInitially() {
 	BLKDEVS=$(find /dev/ -name ${DEV}*)
+	BLKDEVS=$(find /dev/ -name "${DEV}"*)
 	for LINE in $BLKDEVS; do
 		sudo umount $LINE
+		sudo umount "$LINE"
 	done
+}
 zeroBeginning() {
 	dd if=/dev/zero of=/dev/$DEV bs=1M count=8
+	dd if=/dev/zero of=/dev/"$DEV" bs=1M count=8
+}
 partitionEMMC() {
 fdisk -W always /dev/$DEV << EOF
+fdisk -W always /dev/"$DEV" << EOF
+o
+n
+p
@@ @@ -53,12 +53,12 @@ EOF @@
+}
 createEXT4fs() {
 	mkfs.ext4 -O ^metadata_csum,^64bit /dev/${DEV}1
+	mkfs.ext4 -O ^metadata_csum,^64bit /dev/"${DEV}"1
+}
 cdToScript() {
 	TMP=$(dirname "$0")
 	cd $TMP
+	cd "$TMP"
 	mkdir flashEMMC
 	cd flashEMMC
+}
@@ @@ -86,13 +86,13 @@ extractImage() { @@
 mountFS() {
 	mkdir root
 	mount /dev/${DEV}1 root
+	mount /dev/"${DEV}"1 root
 	[ -e ${IMAGE_NAME}.md5 ] && md5sum -c ${IMAGE_NAME}.md5 || downloadImage && extractImage
+}
 flashBootloader() {
 	cd root/boot
 	./sd_fusing.sh /dev/${DEV}
+	./sd_fusing.sh /dev/"${DEV}"
 	cd ../..
+}

Dennis Fink (metalgamer) 1 year and 11 months ago comment on pull request "Fixed some shellcheck warnings" ¶

Status change: Under review

x 1 year and 11 months ago comment on pull request "Fixed some shellcheck warnings" ¶

Status change: Approved

Answer is "ok" (via Matrix chat)

2 comments (0 inline, 2 general)